Upgrade to cryoet-data-portal client v3.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 82.12% 82.36% +0.24%
==========================================
Files 14 14
Lines 660 669 +9
==========================================
+ Hits 542 551 +9
Misses 118 118 ☔ View full report in Codecov by Sentry. |
andy-sweet
approved these changes
Jan 31, 2024
|
|
||
| tomogram: Tomogram = next(tomogram_spacing.tomograms) | ||
| tomogram: Tomogram = tomogram_spacing.tomograms.pop() |
There was a problem hiding this comment.
[0] would be equivalent, but I assume we only expect one element, so it doesn't really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some breaking changes in the latest release. I think this is all that needs to change to support the results from
find()and 1:many relationships being converted fromIterabletolist